Fix conversion of PK columns to identity columns#3859
Merged
katzyn merged 1 commit intoh2database:masterfrom Aug 4, 2023
Merged
Fix conversion of PK columns to identity columns#3859katzyn merged 1 commit intoh2database:masterfrom
katzyn merged 1 commit intoh2database:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historic
IDENTITYdata type creates an implicit primary key constraint. Our implementation ofALTER TABLE name ALTER COLUMN columnName IDENTITYhave a trick for this purpose, but this trick tries to create a second primary key constraint if column already has it. Unfortunately, normal columns were also affected, it wasn't possible to add identity generator to a primary key column with standardALTER TABLE name ALTER COLUMN columnName SET GENERATED { ALWAYS | BY DEFAULT }command. This trick is enhanced to create a primary key constraint only if it doesn't exist.(I think we should remove this undocumented crazy data type in the future, at least from the regular mode, only regular and legacy modes have it.)