Skip to content

Fix typo condtions to conditions#343

Merged
f2c-ci-robot[bot] merged 1 commit intohalo-dev:mainfrom
n0vad3v:typo-condtions
Apr 26, 2024
Merged

Fix typo condtions to conditions#343
f2c-ci-robot[bot] merged 1 commit intohalo-dev:mainfrom
n0vad3v:typo-condtions

Conversation

@n0vad3v
Copy link
Contributor

@n0vad3v n0vad3v commented Apr 26, 2024 •
edited
Loading

condtions should be conditions? 🤔

@vercel
Copy link

vercel bot commented Apr 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 1:56pm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 26, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby April 26, 2024 13:51
ruibaby
ruibaby reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Good catch! thanks

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
guqing
guqing reviewed Apr 26, 2024
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit fd7eac2 into halo-dev:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruibaby ruibaby ruibaby left review comments

@guqing guqing guqing left review comments

Assignees

@ruibaby ruibaby

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@n0vad3v @ruibaby @guqing