saml: truncate issue instant to microseconds#126
Merged
austingebauer merged 1 commit intomainfrom Dec 21, 2023
Merged
Conversation
vinay-gopalan
approved these changes
Dec 21, 2023
vinay-gopalan
left a comment
vinay-gopalan
left a comment
There was a problem hiding this comment.
The fix makes sense based on the explanation of the problem! Great catch, will need to be mindful of different platforms when using time.Now 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR truncates the
IssueInstantof the SAMLAuthNRequestto microseconds. This enables our service provider to be compatible with SAML enterprise applications in Microsoft Entra (formerly Azure AD). I was able to reproduce the failure to parse theIssueInstantand verify this change fixes it in Vault.This is needed because the
AuthnRequestprocessing expects theIssueInstantto have the round-trip format ("o") which has a max of 10^-7 second precision. Gotime.Now()has varying precision depending on which OS it's running on. On linux, the precision is 10^-9 (nanoseconds) which caused the parsing failure. Truncating to 10^-6 (microseconds) fixes it.