Add ability to the SAML test provider to create signed SAML responses#135
Merged
Add ability to the SAML test provider to create signed SAML responses#135
Conversation
hcjulz
requested review from
austingebauer,
jefferai and
jimlambrt
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to the SAML test provider to create signed SAML responses. It uses the goxmldsig library for this purpose, which is also used by the underlaying
gosaml2library used incap/saml.Before, this library used
samltest.id(a test SAML Identity provider), which doesn't exist anymore. The tests for parsing SAML responses have been updated to use the test provider.I'll open a follow up PR to improve the test SAML identity provider in
cap/saml. Areas to improve: