Add way to exclude generated modules from sdists#1046
Closed
lpotmann wants to merge 2 commits intohaskell:masterfrom
Closed
Add way to exclude generated modules from sdists#1046lpotmann wants to merge 2 commits intohaskell:masterfrom
lpotmann wants to merge 2 commits intohaskell:masterfrom
Conversation
Member
Member
|
I definitely think we should go with |
Member
|
@lpotmann I'd like to see |
Member
|
I'm going to close this because it's pretty clear that this belongs in a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one of my projects, I am machine-generating a number of modules, which other parts of the code then import. These need to be specified in the .cabal file, otherwise hard-to-debug linker errors happen. However, then they get included in sdist tarballs, or sdist chokes if they're not present, which is undesirable. This patch lets generated modules be excluded from sdists on the command line with a
--generated-moduleoption.(An alternative (and perhaps more robust) approach would be to add a
generated-modulesfield to cabal files, but that's only just occurred to me and this patch is sitting here!)