Add MHS as a recognized compiler.#9878
Conversation
geekosaur
left a comment
There was a problem hiding this comment.
Does this need additional code for compiler support? (cf. Distribution.Simple.{GHC,HaskellSuite,…})
|
I don't care about additional code right now. I just want to have mhs be recognized as a valid Haskell compiler to be used in .cabal files. To build things with mhs I use mcabal anyway. |
|
Looks like a hash needs to be updated: |
|
Let me rebase to verify CI passes after we worked around the github changes breakage. |
|
@mergify rebase |
✅ Branch has been successfully rebased |
|
Actually, @geekosaur was right all along --- the hashes need to be updated to the ones given in https://github.com/haskell/cabal/actions/runs/8908155162/job/24463289224?pr=9878. @augustss: I'm afraid that's the task of the PR author. We'd also need a tiny changelog file: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#changelog. I think, we can skip a test in this case, but it never hurts to add one. Thank you for the PR! |
|
Is there any chance this fix could be merged soon? |
|
@augustss , for this to be merged you need to update the hashes, like @geekosaur suggested. I would also add a simple comment to specify what MHS is longhand, |
|
I've added a comment, added a changelog entry, and updated the checksums. |
|
It's been sitting for a while, so I take the liberty and apply the delay-passed label. |
|
@mergify backport 3.12 |
✅ Backports have been createdDetails
|
|
@mergify refresh |
✅ Pull request refreshed |
* Add MHS as a recognized compiler. * Add Changelog entry * Add comment. * Update checksums. * Update more checksums. --------- Co-authored-by: Lennart Augustsson <[email protected]> (cherry picked from commit 3169b87) # Conflicts: # Cabal-tests/tests/UnitTests/Distribution/Utils/Structured.hs
|
Thanks! |
* Add MHS as a recognized compiler. (#9878) * Add MHS as a recognized compiler. * Add Changelog entry * Add comment. * Update checksums. * Update more checksums. --------- Co-authored-by: Lennart Augustsson <[email protected]> (cherry picked from commit 3169b87) # Conflicts: # Cabal-tests/tests/UnitTests/Distribution/Utils/Structured.hs * fixup! Add MHS as a recognized compiler. (#9878) --------- Co-authored-by: Lennart Augustsson <[email protected]> Co-authored-by: brandon s allbery kf8nh <[email protected]>
* Add MHS as a recognized compiler. * Add Changelog entry * Add comment. * Update checksums. * Update more checksums. --------- Co-authored-by: Lennart Augustsson <[email protected]>
* Add MHS as a recognized compiler. * Add Changelog entry * Add comment. * Update checksums. * Update more checksums. --------- Co-authored-by: Lennart Augustsson <[email protected]>
|
Too late now, but adding new constructors constitutes a breaking change. It should not have happened without bumping a major version of |
* Add MHS as a recognized compiler. * Add Changelog entry * Add comment. * Update checksums. * Update more checksums. --------- Co-authored-by: Lennart Augustsson <[email protected]>
* Add MHS as a recognized compiler. * Add Changelog entry * Add comment. * Update checksums. * Update more checksums. --------- Co-authored-by: Lennart Augustsson <[email protected]>
The title says it all.