Bump CI to GHC 9.8 and latest versions of actions#573
Merged
kazu-yamamoto merged 3 commits intomasterfrom Mar 25, 2024
Merged
Conversation
Member
andreasabel
commented
Mar 22, 2024
andreasabel
commented
- adjust testes GHC versions to latest 3 plus oldest (GHC 8.0)
- bump actions to latest
- use outputs {ghc,cabal}-version of haskell-actions/setup
- bump stack lts to recommended
- adjust testes GHC versions to latest 3 plus oldest (GHC 8.0)
- bump actions to latest
- use outputs {ghc,cabal}-version of haskell-actions/setup
- bump stack lts to recommended
The container `ubuntu:22.10` does not seem to work anymore. Also, why pin a version of `autoconf`? Shouldn't we test with the native `autoconf` shipped with the OS?
Reason: hsc2hs does not build there.
Member
Author
|
Windows build it broken, likely due to |
andreasabel
commented
Mar 22, 2024
| autoconf: | ||
| runs-on: ubuntu-latest | ||
| container: ubuntu:22.10 | ||
| # container: ubuntu:22.10 |
Member
Author
There was a problem hiding this comment.
We could remove that line altogether.
If it is important that this CI run in a certain container, that should be justified here in a comment.
| apt-get update -y -qq | ||
| apt-get install -y -qq build-essential autoconf${{ env.autoconf_ver }} | ||
| sudo apt-get update -y -qq | ||
| sudo apt-get install -y -qq build-essential autoconf${{ env.autoconf_ver }} |
Member
Author
There was a problem hiding this comment.
sudo is needed for installing on bare Linux runner.
| matrix: | ||
| os: [ 'ubuntu-latest', 'macOS-latest', 'windows-latest' ] | ||
| ghc: [ '8.10', '9.0', '9.2', '9.4', '9.6' ] | ||
| ghc: [ '8.4', '9.4', '9.6', '9.8' ] |
Collaborator
There was a problem hiding this comment.
Should '8.4' be '8.10'?
Member
Author
There was a problem hiding this comment.
Well, the proposal here is to test
- the latest 3 major GHCs, and
- the oldest GHC that is supported cross all OSs.
The latter turned out to be GHC 8.4.
kazu-yamamoto
approved these changes
Mar 25, 2024
Collaborator
kazu-yamamoto
left a comment
kazu-yamamoto
left a comment
There was a problem hiding this comment.
Merge this first.
Then fix Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.