Add Read instance for PortNumber.#145
Conversation
|
@kazu-yamamoto What do you think of this one? It has been languishing for a while. I see no reason not to merge it. |
|
I support this. If we have doctest test cases, it would be much better. |
|
Indeed @bjornbm do you have interest in writing these? Otherwise I can handle it. |
|
I wouldn't say I have an “interest” per se and am pretty swamped so you are welcome to handle it if you have the time. :) Question: Where would the test go? The instance cannot have haddocks (unless things have changed recently?) and I don't see any doctests at the |
|
I will take this. doctest does not exsit at this moment. So, I will merge this first. Then I will add doctest test suite and add doctest test cases for this. |
Add Read instance for PortNumber.
|
Please check two patches above. |
|
Sorry but I'm on travel and don't have a Haskell system available to test this the next two weeks. |
|
This all looks good to me! |
No description provided.