Improve error messages#232
Merged
kazu-yamamoto merged 1 commit intohaskell:masterfrom Mar 17, 2017
spl:improve-error-messages
Merged
Improve error messages#232kazu-yamamoto merged 1 commit intohaskell:masterfrom spl:improve-error-messages
kazu-yamamoto merged 1 commit intohaskell:masterfrom
spl:improve-error-messages
Conversation
* Add module name where missing * Use ioError instead of error and throwIO consistently
Contributor
Author
|
Ping! |
Collaborator
|
I'm very sorry for this long delay. |
Contributor
Author
|
Thanks! I was getting worried that nobody was maintaining |
Closed
eborden
added a commit
that referenced
this pull request
May 17, 2017
* Zero memory of `sockaddr_un` if abstract socket [#220](#220) * Improving error messages [#232](#232) * Allow non-blocking file descriptors via `setNonBlockIfNeeded` [#242](#242) * Update config.{guess,sub} to latest version [#244](#244) * Rename `my_inet_ntoa` to avoid symbol conflicts [#228](#228) * Test infrastructure improvements [#219](#219) [#217](#217) [#218](#218) * House keeping and cleanup [#238](#238) [#237](#237)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the following error in an application:
It took more time than it should have to (1) trace the error to
Network.connectTowhich callsNetwork.Socket.connectand (2) determine that the failure was due to a default use of a Unix socket file that did not exist.After looking at the error messages in
network, I realized that almost none of them included the module name in the location. So, I did a bit of an audit of the error messages. The following error is part of the result, and I find it to be more helpful:These are the highlights:
ioErrorinstead oferrorandthrowIOconsistently