Improve exception error messages for getAddrInfo and getNameInfo#289
Merged
eborden merged 1 commit intohaskell:masterfrom Dec 31, 2017
Merged
Improve exception error messages for getAddrInfo and getNameInfo#289eborden merged 1 commit intohaskell:masterfrom
eborden merged 1 commit intohaskell:masterfrom
Conversation
MaxGabriel
force-pushed
the
improveErrorMessages
branch
from
20b144d to
8490617
Compare
@develop7 ran into an issue with `yesod devel` (yesodweb/yesod#1471) and got the following error message: ``` devel.hs: Network.Socket.getAddrInfo: does not exist (Name or service not known) ``` It would be useful to have a more detailed error message to aid in debugging this exception. The new message looks like this: ``` > getAddrInfo Nothing (Just "127.0.0.1") (Just "foo") *** Exception: Network.Socket.getAddrInfo (called with preferred socket type/protocol: Nothing, host name: Just "127.0.0.1", service name: Just "foo"): does not exist (nodename nor servname provided, or not known) ``` I think a more verbose error message is well worth it, especially since these kind of lower-level, underlying issues can be hard to debug. (I added a similar error message for `getNameInfo` since it was right there)
MaxGabriel
force-pushed
the
improveErrorMessages
branch
from
8490617 to
368697a
Compare
eborden
approved these changes
Dec 31, 2017
Collaborator
eborden
left a comment
eborden
left a comment
There was a problem hiding this comment.
These look great! Thanks.
Contributor
Author
|
Thanks @eborden! Didn’t realize you did stackage and network, thanks for all your work :) |
Contributor
Author
|
Oh wait I'm confusing you with bergmark, sorry :P |
|
There's an issue with this PR: the |
Contributor
Author
|
Oh hm, I assumed that correct usage of the library was to set the undefined fields to something sensible first |
Contributor
Author
|
I see that the docs for So it sounds like expected usage is for those fields to be undefined. I can think of a couple workarounds:
I’d probably implement (1) unless you have further advice on this @eborden |
Collaborator
|
(1) Seems like a reasonable approach. Do you plan to open a PR? |
Contributor
Author
|
Yeah, but I’m going skiing for a few days so might be a bit |
Closed
kazu-yamamoto
pushed a commit
to kazu-yamamoto/network
that referenced
this pull request
Jan 9, 2018
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Jan 9, 2018
kazu-yamamoto
pushed a commit
to kazu-yamamoto/network
that referenced
this pull request
Jan 9, 2018
kazu-yamamoto
added a commit
to kazu-yamamoto/network
that referenced
this pull request
Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@develop7 ran into an issue with
yesod devel(yesodweb/yesod#1471) and got the following error message:It would be useful to have a more detailed error message to aid in debugging this exception. The new message looks like this:
I think a more verbose error message is well worth it, especially since these kind of lower-level, underlying issues can be hard to debug.
(I added a similar error message for
getNameInfosince it was right there)