Use withFdSocket whenever possible; deprecate fdSocket (fixes #396)#398
Closed
fumieval wants to merge 4 commits intohaskell:masterfrom
Closed
Use withFdSocket whenever possible; deprecate fdSocket (fixes #396)#398fumieval wants to merge 4 commits intohaskell:masterfrom
fumieval wants to merge 4 commits intohaskell:masterfrom
Conversation
`fdSocket` is fairly unsafe, because the socket may be finalized (and therefore closed) while the file descriptor is still being used. `withFdSocket` offers a safer way to use the file descriptor.
fumieval
changed the title
Collaborator
|
@fumieval Could you provide a PR description? |
Closed
Contributor
Author
|
@eborden Sure, updated the description |
Collaborator
|
My plan is to add a test case first on a new branch, cherry-pick this PR to pass the test and then merge the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #396 and #397, sockets can be incorrectly closed during
acceptorrecv. This is becausefdSocketdoesn't guarantee a reference for the IORef during the operation, letting the Socket to be GC'd.This MR replaces all the uses of
fdSocketwith @treeowl 'swithFdSocketand ensures that sockets are kept during the actions.