defining CustomSockOpt again with ViewPatterns.#455
defining CustomSockOpt again with ViewPatterns.#455kazu-yamamoto merged 2 commits intohaskell:masterfrom
Conversation
|
If we want, we can make |
treeowl
left a comment
There was a problem hiding this comment.
Don't forget the COMPLETE pragma in case someone decides to use -Wincomplete-patterns.
|
@treeowl Do you suggest the following? |
|
{-# COMPLETE CustomSockOpt #-} |
|
Good call on |
|
The pattern synonym looks fine. Can't comment on how it all fits with the rest of the library, because I'm not familiar with that. |
Credit: David Feuer <[email protected]>
Co-authored-by: Evan Borden <[email protected]>
4093a62 to
c369cb2
Compare
|
Rebased just in case. |
|
Merged. Thank you for your review! |
As David Feuer suggested in haskell-cafe, the
CustomSockOptpattern can be defined withViewPatterns.Relating to #414.