Skip to content

update Github Actions#501

Closed
peterbecich wants to merge 2 commits intohaskell:masterfrom
peterbecich:github-actions-update
Closed

update Github Actions#501
peterbecich wants to merge 2 commits intohaskell:masterfrom
peterbecich:github-actions-update

Conversation

@peterbecich
Copy link
Member

@peterbecich peterbecich commented Jun 15, 2021 •
edited
Loading

@peterbecich peterbecich force-pushed the github-actions-update branch 9 times, most recently from 9100cff to 2cab094 Compare June 15, 2021 02:42
@peterbecich peterbecich force-pushed the github-actions-update branch from 2cab094 to 21924db Compare June 15, 2021 02:56
@peterbecich peterbecich marked this pull request as ready for review June 15, 2021 02:58
@kazu-yamamoto kazu-yamamoto self-requested a review June 15, 2021 06:56
kazu-yamamoto
kazu-yamamoto requested changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.10.5 should not be added at this moment.

.github/workflows/haskell.yml Outdated
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
ghc: ['8.0', '8.2', '8.4', '8.6', '8.8', '8.10']
ghc: ['8.0', '8.2', '8.4', '8.6', '8.8', '8.10.4', '8.10.5']
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add 8.10.5. See https://gitlab.haskell.org/ghc/ghc/-/issues/19968

@kazu-yamamoto
Copy link
Collaborator

kazu-yamamoto commented Jun 18, 2021

@Mistuke Do you understand why network cannot be built on Windows?

@Mistuke
Copy link
Collaborator

Mistuke commented Jun 18, 2021

@Mistuke Do you understand why network cannot be built on Windows?

autoconf 2.70+[1] have several backwards incompatible changes in them. Since msys2 follows Arch Linux's package philosophy it'll always be using bleeding edge. Because your github actions is installing msys2 fresh it'll get latest autoconf which is 2.71.

So it's not really a Windows issue, you can get the same error on Linux with a new enough autoconf. You should be able to fix it by setting AC_CONFIG_AUX_DIR to the directory containing the config.guess and config.sub.

[1] http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=blob_plain;f=NEWS;hb=97fbc5c184acc6fa591ad094eae86917f03459fa

kazu-yamamoto
kazu-yamamoto approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kazu-yamamoto added a commit to kazu-yamamoto/network that referenced this pull request Jun 22, 2021
@kazu-yamamoto
Merge PR haskell#501
a7d2940
@kazu-yamamoto
Copy link
Collaborator

kazu-yamamoto commented Jun 22, 2021

Merged. Thank you for your contribution!

The autoconf issue has been filed in #502.

@kazu-yamamoto kazu-yamamoto mentioned this pull request May 30, 2022
Merged
@kazu-yamamoto kazu-yamamoto mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterbecich @kazu-yamamoto @Mistuke