Conversation
kazu-yamamoto
left a comment
There was a problem hiding this comment.
I don't have M1 Mac yet. But this looks excellent!
|
Merged. Thank you for your contribution! |
|
@villesokk can you test https://downloads.haskell.org/~ghcup/tmp/network-3.1.2.3.tar.gz please? It contains the new files, but configure was generated with autoconf 2.69. I've been trying to test this on GHCs CI, but due go nix cache shenanigans, it might take forever. |
Just to be sure: you would like me to test it on an M1 Mac? |
yes |
|
With GHC 8.10.7, cabal 3.6.0.0 (both installed from brew) and Apple clang 12.0.5 it built successfully. |
|
Could you also test with 3.4.0.0? (if it's not in brew, it's in ghcup) |
|
I compiled cabal-install 3.4.0.0 from Hackage, tried a clean build of network 3.1.2.3 with it and it succeeded. Can I help in some other way (I don't know anything about developing on Windows unfortunately)? |
Just to confirm... you used the network tarball I linked, right? |
|
Yes, I used your .tar.gz on both attempts. |
I finally got around to trying to build Unison on my M1 Mac with an ARM version of Stack instead of through x86 emulation, and I ran into [this issue](haskell/network#510). Bumping the `network` dependency a bit seems to resolve the issue. Stack made a bunch of unrelated changes to the lock file, mostly just moving fields around but in some cases updating their values. I don't know why it moved stuff around, and I can't find any information about how to make it only update a single package. Is this just a thing that Stack does? All of the tests and transcripts run fine with this change, and after kicking the tires a bit I didn't see any issues.
Currently when building network on an M1 Mac I get the following error:
The current versions of
config.{sub,guess}don't recognisearm64-apple. This PR updates these files with versions from GNU Savannah's config.git repository.