Provide functions to sequence evaluations relative to io actions#3
Merged
simonmar merged 4 commits intohaskell:masterfrom Jun 11, 2018
Merged
Provide functions to sequence evaluations relative to io actions#3simonmar merged 4 commits intohaskell:masterfrom
simonmar merged 4 commits intohaskell:masterfrom
Conversation
It is occasionally usefull, to run evaluations at a specific time relative to IO actions. However, 'runEval' defers the evaluation until its result is actually needed. This makes it difficult to reason about, if or when the evaluation is performed. add usingIO and withStrategyIO
Contributor
|
I think this is a good idea, but I'm not convinced we need all three functions. On the flip side, we should probably also offer stToEval :: (forall s. ST s a) -> Eval a |
Contributor
Author
|
Technically one needs only do ...
x <- expression `usingIO` strat
y <- withStrategyIO strat2 . f . g $ x
runEvalIO $ do
...In my testings I never encountered a case, where
|
The merge was necessary, because the internal implementation of `Eval` has changed.
Member
|
This looks OK to me, I'll go ahead and merge. Thanks for adding the test! |
This was referenced Jun 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my way to fix issue #1.