Merged
Conversation
Borgvall
reviewed
Apr 24, 2025
Contributor
Borgvall
left a comment
Borgvall
left a comment
There was a problem hiding this comment.
In some parts this PR has the same issues as treeowls variant.
Collaborator
Author
|
Given that |
Borgvall
approved these changes
Apr 28, 2025
Contributor
Borgvall
left a comment
Borgvall
left a comment
There was a problem hiding this comment.
My comments about misleading documentation of dot are resolved, now. In addition dot has been deprecated, which I approve.
| -- | ||
| -- Perhaps unexpectedly, @r0 `dot` strat == r0@. | ||
| -- 'Control.Monad.<=<' has a more intuitive behaviour (@r0 <=< strat == strat@). | ||
| {-# DEPRECATED dot "'dot' is an unintuitive composition operator. Use 'Control.Monad.<=<` instead." #-} |
Contributor
There was a problem hiding this comment.
Plus one for deprecating dot.
konsumlamm
added a commit
to treeowl/parallel
that referenced
this pull request
May 20, 2025
* Fix dot documentation * Deprecate `dot`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32.
Fix the documentation of
dotand mention<=<as a more intuitive alternative. Also add a proof for the associativity ofdot.cc @Borgvall @treeowl