Merged
Conversation
snoyberg
requested changes
Apr 4, 2018
Collaborator
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
LGTM. Can you add a note to the ChangeLog explaining the modification?
When we fail to create communication pipe, we should cleanup resources before exit. E.g. we should close pipes for stdin, stdout and stderr if they where created. Fixes haskell#122.
Contributor
Author
|
Done. Should I also update package version in cabal file? |
snoyberg
approved these changes
Apr 4, 2018
Collaborator
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
Nope, no version bump necessary right now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we fail to create communication pipe, we should cleanup resources
before exit. E.g. we should close pipes for stdin, stdout and stderr if
they where created. Fixes #122.