Windows: Check if all processes really exited and released resources#159
Merged
snoyberg merged 1 commit intohaskell:masterfrom Nov 5, 2019
Merged
Conversation
snoyberg
requested changes
Nov 5, 2019
Collaborator
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
Looks good. Can you add a ChangeLog entry?
Mistuke
force-pushed
the
wip/wait-for-actual-process-termination
branch
from
be0d0d8 to
8cb23fd
Compare
Contributor
Author
|
Done :) |
bgamari
added a commit
to ghc/ghc
that referenced
this pull request
Nov 5, 2019
This should fix the #17108 and #17249 with the fix from haskell/process#159.
bgamari
added a commit
to ghc/ghc
that referenced
this pull request
Nov 5, 2019
This should fix the #17108 and #17249 with the fix from haskell/process#159.
bgamari
added a commit
to ghc/ghc
that referenced
this pull request
Nov 7, 2019
This should fix the #17108 and #17249 with the fix from haskell/process#159.
bgamari
added a commit
to ghc/ghc
that referenced
this pull request
Nov 7, 2019
This should fix the #17108 and #17249 with the fix from haskell/process#159.
bgamari
added a commit
to ghc/ghc
that referenced
this pull request
Nov 8, 2019
This should fix the #17108 and #17249 with the fix from haskell/process#159.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR makes sure we're only listening to completion events for the
keythat we're interested in. This isn't much of an issue now but the new I/O manager for Windows will exclusively use I/O completion ports. Which means this method may mistakenly handle events it shouldn't have.Secondly it fixes a rare but annoying condition. When you receive a notification on the port that a process has terminated this does not mean that the resources of the process has been flushed.
Previously we were immediately unregister the process once we get the notification. However things like
hsc2hswhich rely on the child process having written a file then may get into a race condition. Control may return to the caller before the file has actually been written.Windows deals with this by returning an exit code
STILL_ACTIVEwhich is to be interpreted as"process has exited but has not yet been cleaned up". If we get such an event we then block and wait for the OS to signal the handle and re-set the exit code.This fixes https://gitlab.haskell.org/ghc/ghc/issues/17108 and https://gitlab.haskell.org/ghc/ghc/issues/17249