Conversation
|
The AppVeyor tests failed on this build. Side note: I think I'll move CI over to Github Actions instead of the Travis/AppVeyor split, just an FYI. |
That test is somewhat broken which is why it sometimes passes and sometimes fails. See https://sourceforge.net/p/mingw/mailman/mingw-users/thread/CAO2ddnbqqTwABiLSpyDN-ynyQR%3D6fRt5Mt94gszkgQoJF-atOA%40mail.gmail.com/#msg30566147 In general there's no guarantee that the PID inside a Cygwin process is the same as the PID in Windows. Cygwin is trying to emulate a posix environment in user space. It will try to have the PIDs match but this may not always succeed which is why this test is flaky. In any case, I've updated the test to read the |
Mistuke
force-pushed
the
fix-terminate-process
branch
11 times, most recently
from
7c9334a to
2856c8d
Compare
|
@snoyberg alright, the test is fixed to work properly on Windows now. |
snoyberg
left a comment
snoyberg
left a comment
There was a problem hiding this comment.
Looks great. One more request: could you add a changelog entry explaining the change?
Mistuke
force-pushed
the
fix-terminate-process
branch
from
2856c8d to
904c107
Compare
|
Done. |
|
Thanks! |
2 participants
Hi,
terminateJobis being called from withinterminateProcesswhich already has a lock on theMVar.This add a new function
terminateJobUnsafewhich does not take anMVarand so is not thread-safe but can be called fromterminateProcesssafely.Fixes #196