posix_spawn: Add support for posix_spawn_file_actions_addchdir_np#304
Merged
bgamari merged 2 commits intohaskell:masterfrom Feb 13, 2024
Merged
posix_spawn: Add support for posix_spawn_file_actions_addchdir_np#304bgamari merged 2 commits intohaskell:masterfrom
bgamari merged 2 commits intohaskell:masterfrom
Conversation
Previously the `configure` script would check for `posix_spawn_file_actions_addchdir` yet then the implementation would look for `HAVE_posix_spawn_file_actions_addchdir_np`. Fix this.
It appears that glibc still has not introduced support for `posix_spawn_file_actions_addchdir`, despite it being ratified by Austin Group. Add support for `posix_spawn_file_actions_addchdir_np` as a stop-gap solution since the removal of the `vfork` path has turned up some pathological cases in the `fork` path in user code.
Member
|
FWIW I raised #303 with a bit more background. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that glibc still has not introduced support for
posix_spawn_file_actions_addchdir, despite it being ratified by Austin Group. Add support forposix_spawn_file_actions_addchdir_npas a stop-gap solution since the removal of thevforkpath has turned up some pathological cases in theforkpath in user code.Also fix a typo which rendered the previous
posix_spawn_file_actions_addchdir_nppath unusable.