Closed
Conversation
codygman
force-pushed
the
add-groupby-initial
branch
from
27ddd81 to
61b3968
Compare
Bodigrim
reviewed
Jul 12, 2020
Contributor
Bodigrim
left a comment
Bodigrim
left a comment
There was a problem hiding this comment.
Please do not omit type signatures. They make code easier to read.
|
|
||
| {-# INLINE groupBy #-} | ||
| groupBy k xs = | ||
| switchL [] |
Contributor
There was a problem hiding this comment.
What's the point? Why not pattern-match immediately?
groupBy k [] = []
groupBy k (h : t) = ...| xs | ||
|
|
||
| -- | 'findIndexOrEnd' is a variant of findIndex, that returns the length | ||
| -- of the string if no element is found, rather than Nothing. |
Contributor
There was a problem hiding this comment.
Is it faster than fromMaybe len (findIndex p)?
I think it is better to pattern-match on result of findIndex in groupBy: if it's Nothing you do not need to make another recursive call.
Merged
Contributor
|
Superseded by #427 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm guessing more will need to be done to get this merged, but I think it would be pretty useful.