Add MINIMAL pragma to Vector & MVector type classes#289
Merged
lehins merged 4 commits intohaskell:masterfrom Jun 8, 2020
Merged
Add MINIMAL pragma to Vector & MVector type classes#289lehins merged 4 commits intohaskell:masterfrom
lehins merged 4 commits intohaskell:masterfrom
Conversation
Shimuuar
force-pushed
the
kh/minimal
branch
2 times, most recently
from
dc5f339 to
9b65b8e
Compare
Contributor
Author
|
Yes, list is indeed minimal. I also thrown in fix for #213 |
lehins
approved these changes
Jun 7, 2020
Contributor
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Few suggestion on haddock, otherwise looks great
Data/Vector/Mutable.hs
Outdated
Comment on lines
+284
to
+289
| -- | Create a mutable vector of the given length. The vector content | ||
| -- should be presumed uninitialized. However exact semantics depends | ||
| -- on vector implementation. For example unboxed and storable | ||
| -- vectors will create vector filled with whatever underlying memory | ||
| -- buffer happens to contain, while boxed vector initializes every | ||
| -- element to @error "..."@. |
Contributor
There was a problem hiding this comment.
Suggested change
| -- | Create a mutable vector of the given length. The vector content | |
| -- should be presumed uninitialized. However exact semantics depends | |
| -- on vector implementation. For example unboxed and storable | |
| -- vectors will create vector filled with whatever underlying memory | |
| -- buffer happens to contain, while boxed vector initializes every | |
| -- element to @error "..."@. | |
| -- | Create a mutable vector of the given length. Boxed vector is | |
| -- initialized with every element set to @error "..."@. | |
| -- | |
| -- @since 0.5 |
Contributor
|
I'd probably say that elements of boxed vectors are initialized with bottoms, but do not overspecify whether it is |
Contributor
Author
Bodigrim
approved these changes
Jun 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment only checked that MINIMAL is indeed minimal and no method is ⊥ by visual inspection
Fixes #11