Add config option to disable printing of container logs#472
Merged
Add config option to disable printing of container logs#472
Conversation
nhudson
force-pushed
the
disable-logging
branch
from
db43a6b to
31ca8c7
Compare
Member
|
@nhudson please rebase thanks for this PR |
Member
|
can you generate the docs using the doc-gen? will be good as well to fetch the latest code from main |
nhudson
force-pushed
the
disable-logging
branch
from
31ca8c7 to
d25e580
Compare
Contributor
Author
|
@cpanato thanks! Let me know if there is anything else. |
Signed-off-by: Nick Hudson <[email protected]>
nhudson
force-pushed
the
disable-logging
branch
from
d25e580 to
3422ef1
Compare
cpanato
approved these changes
Sep 26, 2022
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In some instances
ctwill stall indefinitely if the log output from the containers is too long. This PR introduces a new configuration option that will disable printing of the container logs.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #471Special notes for your reviewer:
I am sure this PR isn't ideal, but I am not really sure how to work around my issue. I can say for sure that since using my patched version of
ctwhere log printing is disabled, I have not hadcthang on any job I have ran locally or in a CI job.