Conversation
Signed-off-by: Rafael Matias <[email protected]>
barnabasbusa
approved these changes
May 31, 2023
37afcf1 to
f358bc3
Compare
Contributor
Author
|
friendly ping @davidkarlsen @cpanato 🙏 |
Contributor
Author
|
Any chance on having someone look at this @davidkarlsen ? |
Member
|
hi @skylenet - sorry for the delay, merging now. Thanks! |
davidkarlsen
approved these changes
Jun 26, 2023
cpanato
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In some cases
kubectl logs ..was hanging for us. This mainly happened with pods that logged lines with a lot of characters.The fix of closing both pipes after reading them successfully did the trick and we weren't getting stuck anymore.
Which issue this PR fixes *:
There are some closed issue related to this problem:
Special notes for your reviewer:
This is how you can reproduce the stuck kubectl logs:
I've also tried using the kubectl request-timeout to see if the command would exit, but that didn't happen. The only way for it to terminate was to close the io readers.
Example of a command that got stuck :