use .helmignore when identifying changed charts#591
Conversation
jouve
force-pushed
the
helmignore
branch
2 times, most recently
from
7983176 to
f492eb8
Compare
jouve
force-pushed
the
helmignore
branch
2 times, most recently
from
c2746ce to
208a95d
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Up |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
jouve
force-pushed
the
helmignore
branch
2 times, most recently
from
0f2f9c2 to
1f90b81
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
up |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
davidkarlsen
left a comment
davidkarlsen
left a comment
There was a problem hiding this comment.
sorry for the late response.
can you rebase so we get a new build and see if the docs step passes?
|
please regen the docs and check in and it will pass |
Signed-off-by: Cyril Jouve <[email protected]>
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
seems ok so far, but did not look in depth, i need a bit more time
Signed-off-by: Cyril Jouve <[email protected]>
|
@cpanato Could you please make a release with this feature? It's confusing that the |
|
@cpanato Great, thank you! |
4 participants
What this PR does / why we need it:
use .helmignore when identifying changed charts.
The use of .helmignore is disabled by default (current behaviour) and enabled with
--use-helmignoreWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #530Special notes for your reviewer:
the FilterFiles function is adapted from https://github.com/helm/helm/blob/main/pkg/chart/loader/directory.go#L46