update .golangci for go1.18#11489
Merged
mattfarina merged 1 commit intohelm:mainfrom Jan 9, 2023
yanggangtony:update-go-lint
Merged
update .golangci for go1.18#11489mattfarina merged 1 commit intohelm:mainfrom yanggangtony:update-go-lint
mattfarina merged 1 commit intohelm:mainfrom
yanggangtony:update-go-lint
Conversation
pull-request-size
bot
added
the
size/XS
Signed-off-by: yanggang <[email protected]>
Contributor
Author
|
Hey, the pr is continued for about 11 days, would anyone take a review? |
yxxhero
requested review from
bacongobbler,
hickeyma,
jdolitsky and
joejulian
Member
|
@yanggangtony Thanks for your work. |
Contributor
Author
|
Collaborator
|
To add some contect: Structcheck has been replaced by unused in future releases of golangci-lint. We are already using that. |
mattfarina
approved these changes
Jan 9, 2023
Collaborator
|
XS so merging. No second reviewer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I see the github ci is as above picture .
So i install the golang-lint version and go version to test..
Before is
After modify the .golangci.yml , the result is
Special notes for your reviewer: