Skip to content

chore: remove unuse untar option#12202

Closed
Abirdcfly wants to merge 1 commit intohelm:mainfrom
Abirdcfly:main
Closed

chore: remove unuse untar option#12202
Abirdcfly wants to merge 1 commit intohelm:mainfrom
Abirdcfly:main

Conversation

@Abirdcfly
Copy link
Contributor

@Abirdcfly Abirdcfly commented Jul 13, 2023

What this PR does / why we need it:
getter.options has parameters untar and its setting function WithUntar().
But it's not used anywhere, not even in the tests.
Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 13, 2023
mattfarina
mattfarina requested changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm follows semantic versioning. We cannot remove this until Helm v4 or the Go API will be broken.

A useful change would be to have a code comment noting that it's deprecated.

@Abirdcfly
Copy link
Contributor Author

Abirdcfly commented Jul 13, 2023

We cannot remove this until Helm v4 or the Go API will be broken.

But options.untar is an Non-capitalized identifier. it can not be exported and can only be accessed from within the same package, and we do not use this identifier in options package...

So, neither options.untar nor WithUntar() will have any effect.

@mattfarina
Copy link
Collaborator

mattfarina commented Jul 18, 2023

@Abirdcfly The issue is with WithUntar. That is a public method that could be used in some calling code for someone using the Helm SDK. Even if it does nothing. Removing it will break their calling code. This is part of the public Helm Go SDK API so we can't remove it until Helm v4. To remove it would violate Semantic Versioning.

@joejulian
Copy link
Contributor

joejulian commented Aug 11, 2023

Thanks for noticing this and making an effort, @Abirdcfly . I'm going to go ahead and close this, though, since it's not something that can be merged.

@joejulian joejulian closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattfarina mattfarina mattfarina requested changes

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Abirdcfly @mattfarina @joejulian