test: add tests for HTML entities#144
Closed
rbanffy wants to merge 5 commits intohtmlhint:developfrom
rbanffy:master
Closed
test: add tests for HTML entities#144rbanffy wants to merge 5 commits intohtmlhint:developfrom rbanffy:master
rbanffy wants to merge 5 commits intohtmlhint:developfrom
rbanffy:master
Conversation
Contributor
|
@rbanffy the world needs more people like you. Just sayin :) |
Contributor
Author
|
@waldyrious we should thank whoever fixes my tests now ;-) |
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:cli:20160615 - https://snyk.io/vuln/npm:minimatch:20160620 - https://snyk.io/vuln/npm:tough-cookie:20160722 Latest report for rbanffy/htmlhint: https://snyk.io/test/github/rbanffy/htmlhint
[Snyk] Fix for 4 vulnerable dependency paths
Contributor
|
I think that can be merged and the change to But we should check later if something like this will work <p>{{ a === 1 && b === 2 ? 'c' : 'd' }}</p> |
thedaviddias
approved these changes
Aug 26, 2018
Contributor
Author
|
It'll take me some time to drop the package.json changes. Feel free to move ahead without them. I'm more concerned with the failing tests. Those I'm not sure how to fix. |
2 tasks
thedaviddias
added
#status: dev in progress ⏳
help wanted
thedaviddias
force-pushed
the
develop
branch
from
5cf8348 to
25843ac
Compare
thedaviddias
changed the title
Member
|
Closing this old PR, re-creating it #386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for checking & and HTML entities