refactoring test files test#276
Merged
thedaviddias merged 4 commits intohtmlhint:developfrom Sep 3, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #276 +/- ##
======================================
Coverage 100% 100%
======================================
Files 1 1
Lines 1 1
======================================
Hits 1 1Continue to review full report at Codecov.
|
thedaviddias
added
enhancement
thedaviddias
added
#status: accepted 👍
and removed
triage
thedaviddias
approved these changes
Sep 3, 2018
thedaviddias
pushed a commit
that referenced
this pull request
Sep 3, 2018
thedaviddias
pushed a commit
that referenced
this pull request
Sep 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
better readable code
up to date ES2015+ code
id-class-value.spec.jsnot touched because pending PR #238spec-char-escape.spec.jsnot touched because pending PR #144therefore, no merge conflict is introduced here
no programming logic was touched
Proposed changes:
"esversion": 6to.jshintrc-nodevartolettoconstdescribeandit)used eslint config
{ "env": { "browser": true, "commonjs": true, "es6": true, "node": true }, "extends": "eslint:recommended", "parserOptions": { "ecmaVersion": 2016, "sourceType": "module" }, "rules": { "arrow-parens": ["warn", "always"], "indent": ["error", 4], "linebreak-style": ["error", "unix"], "quotes": ["error", "single", { "avoidEscape": true }], "no-control-regex": "off", "no-empty": ["error", { "allowEmptyCatch": true }], "no-var": "error", "one-var": ["warn", "never"], "prefer-const": ["warn"], "prefer-template": ["warn"], "semi": ["error", "always"] }, "globals": { "HTMLHint": true, "JSHINT": true, "CSSLint": true } }extra eslint in test folder
{ "env": { "mocha": true } }used prettier config
{ "arrowParens": "always", "printWidth": 100, "singleQuote": true }