refactor: migrate to TypeScript (runtime code changes)#423
Merged
Shinigami92 merged 35 commits intobetafrom May 30, 2020
Merged
refactor: migrate to TypeScript (runtime code changes)#423Shinigami92 merged 35 commits intobetafrom
Shinigami92 merged 35 commits intobetafrom
Conversation
Shinigami92
added
enhancement
Shinigami92
changed the title
This was
linked to
issues
May 25, 2020
Shinigami92
commented
May 25, 2020
|
|
||
| const arrLogs = HTMLHint.format(event.messages, { | ||
| colors: nocolor ? false : true, | ||
| colors: !nocolor, |
Contributor
Author
There was a problem hiding this comment.
We need to add a test to check nocolor set to true and false
Shinigami92
commented
May 25, 2020
thedaviddias
approved these changes
May 30, 2020
Member
thedaviddias
left a comment
thedaviddias
left a comment
There was a problem hiding this comment.
Thanks for this incredible work! Smaller PR and more explicit commit messages would help during the process of review.
Member
|
🎉 This PR is included in version 0.13.1-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 0.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
We want to create a stable code base in which errors can be identified quickly
Proposed changes:
closes #202
closes #277