Simplify HTTP::Connection#read_headers!#456
Conversation
|
I have a feeling that there was a reason why this part was written like that. |
|
Looks good, thanks! |
|
Oh whoops, just noticed @ixti's comment now. My bad. |
|
@ixti From the functionality perspective it should be the same, as the until @parser.headers?
# ...
endwith begin
# ...
end until @parser.headers? |
|
I think that's fine in fact. I might have mistook this with other place - and as we don't have specs for this it seems like more likely. |
|
@janko-m I was referring a bit different thing. But let's keep what you have did. If we will face any issues - we will redo this :D |
This simplifies the implementation of
HTTP::Connection#read_headers!, the behaviour should be preserved.