Use context from completion.CmdCompletionOrList.CandidatesContext instead of conte xt.TODO()#5
Merged
Use context from completion.CmdCompletionOrList.CandidatesContext instead of conte xt.TODO()#5
completion.CmdCompletionOrList.CandidatesContext instead of conte xt.TODO()#5Conversation
…nstead of `context.TODO()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request (English)
Replaced
context.TODO()with the context provided bycompletion.CmdCompletionOrList.CandidatesContext.This allows proper context propagation from
go-multiline-nyduring table/column name completions, enabling cancellation and timeout handling.Changes in this pull request (Japanese)
テーブル名・カラム名補完の際に使用していた
context.TODO()を、completion.CmdCompletionOrList.CandidatesContextが提供するコンテキストに変更しました。 これにより、go-multiline-ny側からのキャンセルやタイムアウトの伝播が正しく行われるようになります。