Support options batch for migrate:rollback.#7531
Merged
limingxinleo merged 9 commits intohyperf:masterfrom Sep 30, 2025
Merged
Conversation
Contributor
Author
|
@limingxinleo @huangdijia 再麻煩有空時 review 一下了 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds batch option support to the migrate:rollback command, allowing users to rollback migrations by batch number instead of just by step count.
- Adds a new
--batchoption to the rollback command that accepts a batch number - Implements
getMigrationsByBatch()method in the migration repository to retrieve migrations by batch number - Updates rollback logic to handle batch-based rollbacks alongside existing step-based rollbacks
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| RollbackCommand.php | Adds batch option and passes it to migrator |
| Migrator.php | Implements batch rollback logic in getMigrationsForRollback method |
| MigrationRepositoryInterface.php | Adds getMigrationsByBatch method signature |
| DatabaseMigrationRepository.php | Implements getMigrationsByBatch method |
| DatabaseMigrationRollbackCommandTest.php | Updates tests to include batch parameter and adds batch-specific test |
| DatabaseMigrationRepositoryTest.php | Adds test for getMigrationsByBatch method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@huangdijia 上面的 review 調整完成了 |
huangdijia
previously approved these changes
Sep 30, 2025
limingxinleo
approved these changes
Sep 30, 2025
limingxinleo
changed the title
batch for migrate:rollback.
Member
|
节后回来发版本哈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.