refactor(async-queue): strengthen Result type handling in Driver and AfterHandle event#7603
Merged
limingxinleo merged 1 commit intohyperf:masterfrom Nov 8, 2025
Conversation
…AfterHandle event - Normalize job handler return value to Result enum, defaulting to Result::ACK for non-Result returns - Remove redundant default case from match expression since all Result cases are explicitly handled - Change AfterHandle event's $result property from nullable Result to required Result type - Eliminate duplicate Result type check when dispatching AfterHandle event This refactoring ensures type safety and consistency in async queue result handling while maintaining backward compatibility for jobs that don't return a Result enum.
limingxinleo
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resultenum, defaulting toResult::ACKfor non-Result returnsdefaultcase from match expression since allResultcases are explicitly handledAfterHandleevent's$resultproperty from nullableResultto requiredResulttypeResulttype check when dispatchingAfterHandleeventChanges
Driver.php (src/async-queue/src/Driver/Driver.php:123-132)
$result = $result instanceof Result ? $result : Result::ACK;default => $this->ack($data)case from match expressionAfterHandledispatch to pass$resultdirectly without type checkAfterHandle.php (src/async-queue/src/Event/AfterHandle.php:20)
public ?Result $result = nulltopublic Result $resultBenefits
AfterHandleevent always receives a validResultenum valueResultenum will automatically getResult::ACKbehaviorResultenum typeTest plan
Resultenum values (ACK,REQUEUE,RETRY,DROP)ACK)AfterHandleevent listeners receive properResultvalues