Improve handling of truncated class names from git pull#511
Merged
isc-tleavitt merged 3 commits intointersystems:mainfrom Oct 2, 2024
Merged
Improve handling of truncated class names from git pull#511isc-tleavitt merged 3 commits intointersystems:mainfrom
isc-tleavitt merged 3 commits intointersystems:mainfrom
Conversation
…to find any matches
…to expand truncated class names from git pull
Collaborator
|
@raymond-rebbeck another great catch - thank you! |
isc-tleavitt
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current way of handling truncated class names from git pull seems to have two major flaws:
For example if the repository has the following base directory structure:
/foo/bar/and contains classA.B.Cstored on disk asA/B/C.cls(where foo and bar have no relation to any class package names)then git pull may provide truncated output such as the following:
.../bar/A/B/C.clsExpandClasseswill try and fail to find a class namedbar.A.B.Cwith no warning generated, the class silently fails to import.ExpandClasseshas been updated so that upon failing to find any class names it will remove period-delimited pieces from the start of the name and try again, until it finds something or runs out of pieces.This would mean for example that after failing to find
bar.A.B.Cit would then tryA.B.Cand find the intended class