Pull request for Issue 709 add locking branch to settings#733
Merged
isc-pbarton merged 14 commits intomainfrom Apr 11, 2025
Merged
Pull request for Issue 709 add locking branch to settings#733isc-pbarton merged 14 commits intomainfrom
isc-pbarton merged 14 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 41.28% 41.24% -0.04%
==========================================
Files 24 24
Lines 3183 3188 +5
==========================================
+ Hits 1314 1315 +1
- Misses 1869 1873 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isc-pbarton
requested changes
Apr 8, 2025
Collaborator
isc-pbarton
left a comment
isc-pbarton
left a comment
There was a problem hiding this comment.
A couple code style nitpicks, otherwise looks good to me
isc-pbarton
approved these changes
Apr 8, 2025
isc-pbarton
previously requested changes
Apr 11, 2025
Collaborator
isc-pbarton
left a comment
isc-pbarton
left a comment
There was a problem hiding this comment.
There's one more thing I missed on this pull request. Can you add a line in the CHANGELOG.md saying this feature was added please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New toggle for "lock branch" to prevent branch switching for namespace.