Import items that don't already exist when compileOnImport is not set#799
Merged
isc-pbarton merged 2 commits intointersystems:mainfrom Jul 10, 2025
Merged
Conversation
raymond-rebbeck
force-pushed
the
import-all-no-compile
branch
2 times, most recently
from
413fee4 to
3ae9784
Compare
isc-pbarton
requested changes
Jul 8, 2025
Collaborator
isc-pbarton
left a comment
isc-pbarton
left a comment
There was a problem hiding this comment.
One fix requested, otherwise looks good.
| set sc = ..ImportItem(internalName, force) | ||
| } else { | ||
| if '..IsInSourceControl(internalName) { | ||
| set sc = ..AddToServerSideSourceControl(internalName) |
Collaborator
There was a problem hiding this comment.
Can run into an error here because sc is not defined if the very first file is not in source control:
<UNDEFINED>ImportRoutines+20^SourceControl.Git.Utils.1 *sc
Contributor
Author
There was a problem hiding this comment.
Thank you, I have updated the branch to address this.
… compileOnImport is not set For an item that is not already in source control, Import All would add it to source control and then if compileOnImport was set the default pull handler would be invoked, which would result in the item being imported too. However, when compileOnImport is not set the default pull handler would not be invoked, and the item would not be imported. This change makes it so that the item is imported when compileOnImport is not set.
raymond-rebbeck
force-pushed
the
import-all-no-compile
branch
from
3ae9784 to
b99d24d
Compare
isc-pbarton
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #798
Import All will now import items when
compileOnImport = 0.Previously items that had also been added to source control would not also be imported as the pull event handler would not be invoked, which would otherwise have imported then.
Prior to 03607e9 items would have been imported as part of adding them to source control, which no longer happens.