Closed
Conversation
This was referenced Apr 28, 2023
Carreau
approved these changes
Apr 28, 2023
Member
Carreau
left a comment
Carreau
left a comment
There was a problem hiding this comment.
Thanks that is great ! I'll review and merge soon.
I'll do a release today so it may not make the cut, but next month for sure !
| .coverage | ||
| *.swp | ||
| .pytest_cache | ||
| .hypothesis |
Member
There was a problem hiding this comment.
You should think of adding this to your global gitignore
Member
|
I merged #14039 And will try to make a release today to see if people complain and try to add the test of this one as well for next month. Hope you had a lot of fun. |
Contributor
Author
|
No need, I just checked by rebasing and this PR is entirely redundant with #14039 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 678 - Enriching Exceptions with Notes, is in my admittedly biased opinion a really nice way to attach messages to existing exceptions. Over the last year, it's been adopted by Hypothesis, Pytest, the standard library, and in a variety of other places I don't track so closely.
It's therefore unfortunate that today, notes are completely ignored by
ultratb!Since this bit one of my students at a conference tutorial, I thought I'd send in a PR to fix it before next time 😁 #13753 is similar but less severe for this use-case.