[PCF] Fix bufferization bugs for generic and loop ops#23446
Merged
qedawkins merged 2 commits intoiree-org:mainfrom Feb 18, 2026
Merged
[PCF] Fix bufferization bugs for generic and loop ops#23446qedawkins merged 2 commits intoiree-org:mainfrom
qedawkins merged 2 commits intoiree-org:mainfrom
Conversation
Three independent bug fixes: 1. Preserve num_leading_args when bufferizing pcf.generic. The builder defaults to 0, but the execute region's block arguments include leading args from the initialize region. 2. Fix pcf.read_slice bufferization to use the result tensor shape (the slice sizes) instead of the full source sref shape when computing the memref type. This fixes memref.copy shape mismatches. 3. Use init buffers directly for tied results in pcf.generic and pcf.loop bufferization. This lets the bufferization framework know the result aliases the init, eliminating extraneous memref.copy operations. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Max191
approved these changes
Feb 18, 2026
...ler/src/iree/compiler/Codegen/Dialect/PCF/ExternalInterfaces/BufferizationExternalModels.cpp
Outdated
Show resolved
Hide resolved
...ler/src/iree/compiler/Codegen/Dialect/PCF/ExternalInterfaces/BufferizationExternalModels.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent bug fixes:
Preserve num_leading_args when bufferizing pcf.generic. The builder defaults to 0, but the execute region's block arguments include leading args from the initialize region.
Fix pcf.read_slice bufferization to use the result tensor shape (the slice sizes) instead of the full source sref shape when computing the memref type. This fixes memref.copy shape mismatches.
Use init buffers directly for tied results in pcf.generic and pcf.loop bufferization. This lets the bufferization framework know the result aliases the init, eliminating extraneous memref.copy operations.