[CMake][Python] Bump minimum CMake version to 3.26#23607
Merged
kuhar merged 2 commits intoiree-org:mainfrom Mar 3, 2026
Merged
[CMake][Python] Bump minimum CMake version to 3.26#23607kuhar merged 2 commits intoiree-org:mainfrom
kuhar merged 2 commits intoiree-org:mainfrom
Conversation
kuhar
requested review from
MaheshRavishankar,
RattataKing,
amd-eochoalo and
marbre
kuhar
requested review from
ScottTodd,
benvanik and
stellaraccident
as code owners
CMake 3.26 added FindPython's Development.SABIModule component, which is required for building Python Stable ABI (abi3) extension modules. With this minimum version, we can unconditionally request Development.SABIModule upfront in the Python find_package calls, before deciding whether to enable abi3. This is necessary because the SABI module must be found early — the same place we find Development.Module — and cannot be deferred to after the abi3 option is resolved. CMake 3.26 availability: Source │ Version ──────────────────────────┼───────── pip install cmake │ 4.2.3 Homebrew │ 4.2.3 Chocolatey (Windows CI) │ 4.2.3 Ubuntu 24.04 (apt) │ 3.28.3 Ubuntu 22.04 (apt) │ 3.22.1 ✗ (use pip or Kitware APT repo) Debian 12 bookworm (apt) │ 3.25.1 ✗ (3.31.6 in backports) Co-Authored-By: Claude Opus 4.6 <[email protected]>
amd-eochoalo
approved these changes
Mar 2, 2026
Contributor
amd-eochoalo
left a comment
amd-eochoalo
left a comment
There was a problem hiding this comment.
Thanks!
CMake 3.31.2 fixed a bug related to SABIModule
FindPython: Ensure SABIModule is found in all cases
I looked a bit further and I think it may be this one which relates to cross compiling on Windows. I don't believe we need this patch, just making a note that this issue exist and was solved in version 3.31.2 .
Member
Author
I think we should be fine because we always request the interpreter component: Line 748 in a21fa38 Thanks for a thorough review BTW, I a wasn't aware of these potential teething issues. |
Member
Author
|
We need to update cmake on |
Member
Author
Done, as simple as: sudo apt remove cmake -yqq
pip install --user cmake |
Member
Author
|
Extra data points:
|
Member
Author
|
Nobody borough up concerns and the CI passed, merging |
kuhar
added a commit
to kuhar/iree
that referenced
this pull request
Mar 3, 2026
I want to make sure we exercise stable ABI builds in our default development flows, not only when building wheels. Auto-detect `IREE_ENABLE_PYTHON_STABLE_ABI` after `find_package(Python)` instead of requiring it to be explicitly set. The cache variable can still be overridden with `-DIREE_ENABLE_PYTHON_STABLE_ABI=ON/OFF`. Since CMake 3.26 is now the minimum, `Development.SABIModule` is always requested unconditionally in `find_package`: iree-org#23607. Co-Authored-By: Claude Opus 4.6 <[email protected]>
kuhar
added a commit
to kuhar/iree
that referenced
this pull request
Mar 3, 2026
I want to make sure we exercise stable ABI builds in our default development flows, not only when building wheels. Auto-detect `IREE_ENABLE_PYTHON_STABLE_ABI` after `find_package(Python)` instead of requiring it to be explicitly set. The cache variable can still be overridden with `-DIREE_ENABLE_PYTHON_STABLE_ABI=ON/OFF`. Since CMake 3.26 is now the minimum, `Development.SABIModule` is always requested unconditionally in `find_package`: iree-org#23607. Co-Authored-By: Claude Opus 4.6 <[email protected]>
kuhar
added a commit
to kuhar/iree
that referenced
this pull request
Mar 3, 2026
I want to make sure we exercise stable ABI builds in our default development flows, not only when building wheels. Auto-detect `IREE_ENABLE_PYTHON_STABLE_ABI` after `find_package(Python)` instead of requiring it to be explicitly set. The cache variable can still be overridden with `-DIREE_ENABLE_PYTHON_STABLE_ABI=ON/OFF`. Since CMake 3.26 is now the minimum, `Development.SABIModule` is always requested unconditionally in `find_package`: iree-org#23607. Co-Authored-By: Claude Opus 4.6 <[email protected]>
kuhar
added a commit
to kuhar/iree
that referenced
this pull request
Mar 3, 2026
I want to make sure we exercise stable ABI builds in our default development flows, not only when building wheels. Auto-detect `IREE_ENABLE_PYTHON_STABLE_ABI` after `find_package(Python)` instead of requiring it to be explicitly set. The cache variable can still be overridden with `-DIREE_ENABLE_PYTHON_STABLE_ABI=ON/OFF`. Since CMake 3.26 is now the minimum, `Development.SABIModule` is always requested unconditionally in `find_package`: iree-org#23607. Co-Authored-By: Claude Opus 4.6 <[email protected]>
kuhar
added a commit
to kuhar/iree
that referenced
this pull request
Mar 3, 2026
I want to make sure we exercise stable ABI builds in our default development flows, not only when building wheels. Auto-detect `IREE_ENABLE_PYTHON_STABLE_ABI` after `find_package(Python)` instead of requiring it to be explicitly set. The cache variable can still be overridden with `-DIREE_ENABLE_PYTHON_STABLE_ABI=ON/OFF`. Since CMake 3.26 is now the minimum, `Development.SABIModule` is always requested unconditionally in `find_package`: iree-org#23607. Co-Authored-By: Claude Opus 4.6 <[email protected]>
kuhar
added a commit
that referenced
this pull request
Mar 3, 2026
…GIL (#23629) I want to make sure we exercise stable ABI builds in our default development flows, not only when building wheels. Auto-detect `IREE_ENABLE_PYTHON_STABLE_ABI` after `find_package(Python)` instead of requiring it to be explicitly set. The cache variable can still be overridden with `-DIREE_ENABLE_PYTHON_STABLE_ABI=ON/OFF`. Since CMake 3.26 is now the minimum, `Development.SABIModule` is always requested unconditionally in `find_package`: #23607. ci-extra: all Co-authored-by: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 3.26 added FindPython's
Development.SABIModulecomponent, which is required for building Stable ABI (abi3). With this minimum version, we can unconditionally requestSABIModuleupfront in the Pythonfind_packagecalls, before deciding whether to enable abi3. This is appealing because the SABI module must be found early and cannot be deferred to after the abi3 option is resolved; otherwise we need the user to decide through cmake flags.CMake 3.26 availability:
pip install cmake: 4.2.3
Homebrew: 4.2.3
Chocolatey (Windows CI): 4.2.3
Ubuntu 24.04 (apt): 3.28.3
Ubuntu 22.04 (apt): 3.22.1 (use pip or Kitware APT repo)
Debian 12 bookworm (apt): 3.25.1 (3.31.6 in backports)
ci-extra: all