[Codegen] Remove attention transpose intrinsic hacks#23633
Merged
Groverkss merged 2 commits intoiree-org:mainfrom Mar 4, 2026
Merged
[Codegen] Remove attention transpose intrinsic hacks#23633Groverkss merged 2 commits intoiree-org:mainfrom
Groverkss merged 2 commits intoiree-org:mainfrom
Conversation
Groverkss
requested review from
MaheshRavishankar,
Max191,
Yu-Zhewen,
hanhanW,
jtuyls,
krzysz00,
kuhar,
nirvedhmeshram and
qedawkins
as code owners
Contributor
Author
|
Depends on #23631 |
Groverkss
force-pushed
the
remove_attention_hacks
branch
from
1e1df58 to
42dfadf
Compare
sommerlukas
approved these changes
Mar 4, 2026
Contributor
sommerlukas
left a comment
sommerlukas
left a comment
There was a problem hiding this comment.
Just small stuff.
Do we still have a e2e or pipeline test that doesn't use col_major = true to ensure that path still works?
bangtianliu
added a commit
that referenced
this pull request
Mar 13, 2026
…thon binding (#23757) PR #23633 removes the `attention_qk_matmul` and `attention_pv_matmul` marker attributes from attention decomposition configs, replacing them with a new `col_major = true` parameter on MMA intrinsics. This PR updates the Python bindings to support the `col_major `parameter, enabling the tuner to generate attention configs compatible with the new approach. After this PR, I will also add the required changes to the tuner side. Assisted-by: [Claude Code](https://claude.ai/code) Signed-off-by: Bangtian Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #23631 we will be using the analysis to determine conflicts, which allows us to undo a bunch of hacks we did earlier to not have conflicts between the chained mma in attention.
This patch simply sets the intrinsic to be col major in KernelConfig and rest of the pipeline automatically picks up if there needs to be a intermediate conflict using shared memory or not.