[Codegen] Migrate ArgCompareOp to VectorizableOpInterface#23656
Merged
Conversation
hanhanW
requested review from
Groverkss,
MaheshRavishankar,
Max191 and
qedawkins
as code owners
hanhanW
force-pushed
the
users/hanhanW/vec-iface-c2a
branch
2 times, most recently
from
d8935f8 to
5e497e7
Compare
Contributor
Author
This was referenced Mar 6, 2026
hanhanW
force-pushed
the
users/hanhanW/vec-iface-c2a
branch
from
5e497e7 to
c5f784e
Compare
This was referenced Mar 9, 2026
Groverkss
approved these changes
Mar 10, 2026
- Add external model for IREE::LinalgExt::ArgCompareOp, inlining the vectorization logic from vectorizeLinalgExtArgCompare. - Remove ArgCompareOp from GenericVectorization TypeSwitch and candidate isa<> check (now dispatched through interface). Signed-off-by: hanhanW <[email protected]>
hanhanW
force-pushed
the
users/hanhanW/vec-iface-c2a
branch
from
c5f784e to
a4dc64b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new tests because it is an NFC in terms of functionality. It just follows different mechanism for vectorization.
It is a step towards https://lists.lfaidata.foundation/g/iree-technical-discussion/message/15
Assisted-by: Claude