[Codegen] Add PackLayoutAttr and VectorLayoutInterface to iree_map dialect#23672
Merged
Groverkss merged 4 commits intoiree-org:mainfrom Mar 12, 2026
Merged
[Codegen] Add PackLayoutAttr and VectorLayoutInterface to iree_map dialect#23672Groverkss merged 4 commits intoiree-org:mainfrom
Groverkss merged 4 commits intoiree-org:mainfrom
Conversation
Contributor
Author
|
Depends on #23671, please review top commit only |
…alect Adds `PackLayoutAttr` to the `iree_map` dialect — a wrapper around `PackMapAttr` that stores the map in by-mode-coalesced form and implements `VectorLayoutInterface` for use in vector distribution. Includes the ExternalInterfaces library wiring. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Groverkss
force-pushed
the
iree-map-dialect-patch-2
branch
from
b004227 to
42bc658
Compare
kuhar
reviewed
Mar 11, 2026
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/IR/IREEMapAttrs.cpp
Outdated
Show resolved
Hide resolved
sommerlukas
reviewed
Mar 12, 2026
Contributor
sommerlukas
left a comment
sommerlukas
left a comment
There was a problem hiding this comment.
A few small comments and questions.
...c/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/test/pack_layout_vector_analysis.mlir
Show resolved
Hide resolved
...c/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/test/pack_layout_vector_analysis.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Show resolved
Hide resolved
sommerlukas
approved these changes
Mar 12, 2026
Contributor
sommerlukas
left a comment
sommerlukas
left a comment
There was a problem hiding this comment.
LGTM, just two really minor nits.
...c/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/test/pack_layout_vector_analysis.mlir
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/Map/ExternalInterfaces/VectorLayoutInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PackLayoutAttrto theiree_mapdialect — a wrapper aroundPackMapAttrthat stores the map in by-mode-coalesced form andimplements
VectorLayoutInterfacefor use in vector distribution.Includes the ExternalInterfaces library wiring.
Co-Authored-By: Claude Sonnet 4.6 [email protected]