Use TileSwizzle for inner_tiled layout on CPU#23705
Merged
bjacob merged 1 commit intoiree-org:mainfrom Mar 9, 2026
Merged
Conversation
bjacob
requested review from
Groverkss,
MaheshRavishankar,
Max191,
hanhanW,
jtuyls,
krzysz00,
nirvedhmeshram and
qedawkins
as code owners
krzysz00
approved these changes
Mar 9, 2026
Contributor
krzysz00
left a comment
krzysz00
left a comment
There was a problem hiding this comment.
This all looks fairly NFC to me, approved
compiler/src/iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenTypes.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Benoit Jacob <[email protected]>
hanhanW
reviewed
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Can you move the declarations to IREECPUTypes.h?
When I initiated it, I only wanted to avoid numbers of includes. Some time later, there was a discussion, and I'm +1 on what Ben said: https://discord.com/channels/689900678990135345/689900680009482386/1417237795914907659
I usually just have a FooTypes.h that includes everything but the ops - the ops are often the biggest thing I want to avoid polluting scope with
(attrs/interfaces/etc are type-like, at least, in that they are C++ types... is what I tell myself lol)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows removing
CPUOpaqueMmaLayout, so CPU doesn't need any CPU-specific data structure anymore.This involved moving some code out of GPUTileSwizzle.* into IREECodegenTypes where TileSwizzle is defined.
As these TileSwizzle objects are what determines the tile shapes tested by
iree_cpu_inner_tiled_ops.mlir, this test provides test coverage for this PR.