Conversation
Godin
changed the title
marchof
reviewed
Jun 4, 2019
org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/KotlinDefaultArgumentsFilter.java
Outdated
Show resolved
Hide resolved
marchof
reviewed
Jun 4, 2019
org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/KotlinDefaultArgumentsFilter.java
Outdated
Show resolved
Hide resolved
marchof
reviewed
Jun 4, 2019
| return; | ||
| } | ||
|
|
||
| if (KotlinDefaultArgumentsFilter |
Member
There was a problem hiding this comment.
Side note: When I see this I more and more like @Godin 's idea to separate filters for different compilers.
Member
Author
There was a problem hiding this comment.
@marchof don't know about whom you're talking 😆
Not sure that separation can remove this dependency between filters, i.e. not every but some synthetic methods anyway should be filtered in Kotlin.
marchof
requested changes
Jun 4, 2019
Member
marchof
left a comment
marchof
left a comment
There was a problem hiding this comment.
Some minor formal issues from my side.
Member
Author
|
@marchof fixed, also updated javadoc of filter according to changes, please re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #773 constructors in Kotlin can have default arguments with branches, what unfortunately was overlooked during implementation of #774 - currently we filter them out, because they gets compiled differently than functions:
results in constructor with following signature
This was discovered during implementation of #887.