ProbeInserter should update indexes of local variables in annotations#894
Merged
ProbeInserter should update indexes of local variables in annotations#894
Conversation
marchof
requested changes
Jun 10, 2019
Member
marchof
left a comment
There was a problem hiding this comment.
Looks good beside two formal issues.
org.jacoco.core.test/src/org/jacoco/core/internal/instr/ProbeInserterTest.java
Outdated
Show resolved
Hide resolved
org.jacoco.core/src/org/jacoco/core/internal/instr/ProbeInserter.java
Outdated
Show resolved
Hide resolved
marchof
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
compilation (
javac -g Example.java) ofresults (
javap -v -p Example.class) inafter instrumentation (
java -jar jacoco-0.8.4/lib/jacococli.jar instrument Example.class --dest instrumented && javap -v -p instrumented/Example.class)where
indexinRuntimeInvisibleTypeAnnotationsis still1, whereas should be2.This was found during work on #893