Add charge to stoichiometry method (and test)#2
Merged
jaimergp merged 6 commits intojaimergp:masterfrom Aug 5, 2016
Merged
Conversation
Author
|
The convenience method allows one to do this: |
Owner
|
That's cool! One thing though: do we want to be explicit when there's only one atom of a given element? I find the "1" after the O really weird... |
Author
|
Here you go. Also made it compliant with the Hill system, which I think is the standard. |
Author
|
Having it be a property makes it work more like an attribute: |
Owner
|
LGTM! |
jaimergp
pushed a commit
that referenced
this pull request
Feb 2, 2018
Test shape of grads for all possible parsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.