Don't add the link if it already exists#63
Merged
jerone merged 2 commits intojerone:masterfrom Jul 7, 2015
Merged
Conversation
When I use browser history to to back/forward on github, every time I see the main repo page, it creates a new link below the others. This fixes that--it switches to using an id instead of a class, and it'll only make an element if there isn't one already. I'm using chrome with tampermonkey if that makes a difference.
Owner
There was a problem hiding this comment.
Can you use double quotes ", like the rest of the code.
Owner
|
Thanks for this great PR. I encountered this issue many times myself (double links), but never got around to fix it. I gave some minor style feedback; if you fix those I'll merge and release as soon as I can. |
jerone
added a commit
that referenced
this pull request
Jul 7, 2015
🐛 Don't add the link if it already exists;
Owner
|
Awesome thanks! 🎉 🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I use browser history to to back/forward on github, every time I see the main repo page, it creates a new link below the others. This fixes that--it switches to using an id instead of a class, and it'll only make an element if there isn't one already.
I'm using chrome with tampermonkey if that makes a difference.