Skip to content

Improve property key query for Proxy objects#3797

Merged
dbatyai merged 1 commit intojerryscript-project:masterfrom
galpeter:fix_proxy_symbol_keys
May 26, 2020
Merged

Improve property key query for Proxy objects#3797
dbatyai merged 1 commit intojerryscript-project:masterfrom
galpeter:fix_proxy_symbol_keys

Conversation

@galpeter
Copy link
Contributor

Property key query for Proxy objects always returned all keys
even if no symbols were requested symbols were present in the
resulting array.

Fixes: #3787

Property key query for Proxy objects always returned all keys
even if no symbols were requested symbols were present in the
resulting array.

JerryScript-DCO-1.0-Signed-off-by: Peter Gal [email protected]
@galpeter galpeter added bug Undesired behaviour ES2015 Related to ES2015 features labels May 26, 2020
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit 908240b into jerryscript-project:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ES2015 Related to ES2015 features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion 'ecma_is_value_string (value)' failed at jerry-core/ecma/base/ecma-helpers-value.c(ecma_get_string_from_value):742

3 participants