Merged
Conversation
* add kafka as a new logging backend * update configuration to allow defining a kafka logger * updated the docker-compose to allow to run different backends
* add kafka as a new logging backend * added required configuration definition to allow setting up a kafka logger * updated the docker-compose to allow to run different backends * update code to use the new logger
* fix conflicts
Contributor
Author
|
I fixed the conflict, also used the new |
javuto
approved these changes
Oct 8, 2024
Collaborator
|
PR looks good, thank you! 🙏 IIRC in the other PR you opened there were some changes to the Thanks again! |
Collaborator
|
Nevermind my comment about the Good to merge! 🚢 |
Contributor
Author
|
Awesome, thanks for the review. @javuto 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @javuto. This PR adds the kakfa support to osctrl, I would appreciate if you can go through the changes and give me your feedbacks.